Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin support for dbstat table #3051

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

FaFre
Copy link
Contributor

@FaFre FaFre commented Jun 16, 2024

After simolus3/sqlite3.dart#237 landed, I added the dbstat table as a builtin table to the sqlparser.

Open question is, shall the inclusion of the dbstat table be controlled by an option (like its the case for json or fts)?

Copy link
Owner

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But I think this should be guarded behind an option (we're usually pretty cautious with the functionality we assume, we also expect a fairly old sqlite3 version without a builder option telling us. This helps users on platforms not using sqlite3_flutter_libs).

I think the best way to expose this is to put dbstat into a module and also refactor sqlparser so that modules can add their own default tables. That would also potentially allow us to analyze things like CREATE VIRTUAL TABLE stat USING dbstat(main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants