Extract song count from text #609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnHKoh
force-pushed
the
song_count_fix
branch
2 times, most recently
from
ffc0eba
to
1d62e98
Compare
sigma67
reviewed
Jun 21, 2024
| song_count = second_subtitle_runs[has_views + 0]["text"].split(" ") | ||
| song_count = to_int(song_count[0]) if len(song_count) > 1 else 0 | ||
| song_count_text = second_subtitle_runs[has_views + 0]["text"] | ||
| song_count_search = re.search(r"\d+", song_count_text) |
There was a problem hiding this comment.
Thanks for the contribution. Could you please add a test to check that it works for all supported languages?
Not sure what oddities we might be missing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use RegEx search to search for track count integer instead of using indexing. If the number cannot be extracted, return 0 as a fallback. I never hit the error in parsers, but seeing as the logic is the same, I went ahead and changed it there too.
Addresses #608