-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix composer install when no ready-made-env exist #65
base: main
Are you sure you want to change the base?
Conversation
# Patch Drush to fix `drush cr` when core is symlinked | ||
# https://github.com/drush-ops/drush/pull/4713 | ||
cd "$GITPOD_REPO_ROOT" && \ | ||
patch -p1 < "$GITPOD_REPO_ROOT"/src/composer-drupal-core-setup/drush-cr-when-core-is-symlinked.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this patch fail if a different version of drush is installed? It seems sort of brittle without being able to determine if it should be patched or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question...
https://github.com/Weitzman said this bug will not be fixed in Drush, but a problem that should get fixed in Drupal core itself.
(But I think that even if drupal 9.4 will get this fixed, all previous Drupal versions will still have that issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference: drush-ops/drush#4713 (comment)
The Problem/Issue/Bug
Fixes #64
How this PR Solves The Problem
composer create-project
, when there were no ready-made-envs for that drupal version.DP_PHP_VERSION=8.0
in URL params (will become an official option when new browser extension is released)drush si
, it doesn't connect to ddev'sdb
, and try to work withdrupal
database instead.Manual Testing Instructions
Open this URL -
https://gitpod.io/#DP_PROJECT_NAME=drupal,DP_ISSUE_FORK=drupal-3257163,DP_ISSUE_BRANCH=feature%2F3257163-drupal_media_bundle,DP_PROJECT_TYPE=project_core,DP_MODULE_VERSION=10.0.x,DP_CORE_VERSION=10.0.x,DP_PATCH_FILE=,DP_INSTALL_PROFILE=standard,DP_PHP_VERSION=8.0/https://github.com/shaal/drupalpod/tree/drupal10
Related Issue Link(s)
Release/Deployment notes