Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execve syscall code in ropchain generator #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakelamberson
Copy link

@jakelamberson jakelamberson commented Jul 28, 2023

Closes #170

Fixes a message in the x86_64 chain generator to display the correct syscall.

The original issue notes that an incorrect syscall code is displayed. I discovered that an incorrect syscall code is present in the actual chain generator for the x86 version. x86_64 is correct. This pull request fixes both generators' print statements and changes the execve code in the x86 chain generator's gadget creator to the correct 0x3b.

@sashs
Copy link
Owner

sashs commented Aug 18, 2023

Are you sure, that this fix the issue? The changes shows only a change in the message

Also use hex-formatted index in the ropchain generator to be more
consistent with the x86 generator (this is not a functional
change).
@jakelamberson
Copy link
Author

jakelamberson commented Jun 26, 2024

@sashs Yes, this is right. The rop chain values are already correct. Just the message printed has the improper code.

I also went ahead and also updated the indices used in the generator to be hex-formatted to be more consistent with x86 (non-functional change). You can take or leave that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ropchain generator displays incorrect syscall code for execve
2 participants