Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify arguments and results only when logging is enabled #463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

isra17
Copy link

@isra17 isra17 commented Jun 7, 2024

One of our profiling profile shows that 40% of computing time is spent in repr call from ARQ. At the moment, even without logging this get called, which can be expensive on large inputs.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (94cd878) to head (5fe243b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   96.27%   96.49%   +0.21%     
==========================================
  Files          11       11              
  Lines        1074     1083       +9     
  Branches      209      191      -18     
==========================================
+ Hits         1034     1045      +11     
  Misses         19       19              
+ Partials       21       19       -2     
Files Coverage Δ
arq/utils.py 100.00% <100.00%> (ø)
arq/worker.py 97.37% <100.00%> (+0.20%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1315583...5fe243b. Read the comment docs.

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a test.

@isra17
Copy link
Author

isra17 commented Jun 14, 2024

LGTM, can you add a test.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants