Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache JWT manager so it's not reimported dynamically #16141

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

patrys
Copy link
Member

@patrys patrys commented Jun 13, 2024

Port of #16135

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@patrys patrys added the 3.17 label Jun 13, 2024
@db-queries
Copy link

db-queries bot commented Jun 13, 2024

Here is the report for d278d32 (saleor:cache-jwt-manager-317)
Missing base report (543e161). The results couldn't be compared.

No differences were found.

@kadewu kadewu requested a review from a team June 13, 2024 11:11
@patrys patrys requested a review from cmiacz June 19, 2024 00:07
@patrys patrys merged commit 93f06a7 into 3.17 Jun 19, 2024
7 checks passed
@patrys patrys deleted the cache-jwt-manager-317 branch June 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants