Fix: Conditionally Render Company Logo in Experience Card #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:![]()
tag in the experience card component.
Added a condition to check if cardInfo.companylogo exists before rendering the
Reason for Change:
Ensures that a circular logo icon is displayed only when a company logo is provided. This prevents the display of an empty circular icon when cardInfo.companylogo is not defined, improving the user experience.
Testing Done:
Tested the change locally with scenarios where cardInfo.companylogo is both defined and undefined.
Verified that the experience card renders correctly in both cases without errors.
Additional Notes:
This change enhances the component's robustness by handling cases where the company logo is not available gracefully.