fix: move paragraph separation back to two newlines #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 32bd990 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yisding
commented
Jun 5, 2024
| // many documents will use it. | ||
| // NOTE this is different from Python because in Python a lot of the heavy lifting for paragraph separation | ||
| // is already handled by NLTK, but we don't have that option here. | ||
| export const defaultParagraphSeparator = /\n\n|\r\n\r\n|\r\r/g; |
There was a problem hiding this comment.
This way we decouple the document encoding from the OS that the user is currently running on.
himself65
approved these changes
Jun 5, 2024
himself65
changed the title
| ].join( | ||
| typeof this.paragraphSeparator === "string" | ||
| ? this.paragraphSeparator | ||
| : "\n\n", |
There was a problem hiding this comment.
\n\n works for all envs?
| @@ -55,10 +53,9 @@ export function cjkSentenceTokenizer(sentence: string): string[] { | |||
| return slist.filter((s) => s.length > 0); | |||
| } | |||
|
|
|||
| export const defaultParagraphSeparator = EOL + EOL + EOL; | |||
There was a problem hiding this comment.
wasn't the problem that we're not using export const defaultParagraphSeparator = EOL + EOL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.