Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting log level when cluster is started #907

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Setting log level when cluster is started #907

merged 2 commits into from
Jun 26, 2024

Conversation

BelSasha
Copy link
Contributor

No description provided.

@BelSasha Graphite App
Copy link
Contributor Author

BelSasha commented Jun 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BelSasha and the rest of your teammates on Graphite Graphite

@BelSasha BelSasha changed the title enable to set log level [WIP] Setting log level when cluster is started Jun 18, 2024
@BelSasha BelSasha force-pushed the sb/set_cluster_log_level branch 2 times, most recently from f85f2fa to 69bcd4b Compare June 20, 2024 13:13
@BelSasha BelSasha mentioned this pull request Jun 20, 2024
Merged
@BelSasha BelSasha changed the title [WIP] Setting log level when cluster is started Setting log level when cluster is started Jun 20, 2024
@BelSasha BelSasha marked this pull request as ready for review June 23, 2024 06:57
jlewitt1
jlewitt1 reviewed Jun 23, 2024
View reviewed changes
runhouse/main.py Outdated Show resolved Hide resolved
jlewitt1
jlewitt1 reviewed Jun 23, 2024
View reviewed changes
runhouse/main.py Outdated Show resolved Hide resolved
@BelSasha BelSasha force-pushed the sb/set_cluster_log_level branch 3 times, most recently from 5f32c54 to a470515 Compare June 24, 2024 07:44
@BelSasha BelSasha requested a review from jlewitt1 June 24, 2024 09:41
jlewitt1
jlewitt1 reviewed Jun 24, 2024
View reviewed changes
runhouse/logger.py Outdated Show resolved Hide resolved
jlewitt1
jlewitt1 reviewed Jun 24, 2024
View reviewed changes
runhouse/logger.py
@@ -1,7 +1,10 @@
import logging
import logging.config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we import this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in the get_logger() method @jlewitt1

jlewitt1
jlewitt1 reviewed Jun 24, 2024
View reviewed changes
runhouse/main.py Outdated Show resolved Hide resolved
@BelSasha BelSasha force-pushed the sb/set_cluster_log_level branch 2 times, most recently from 3d66966 to 71a3de6 Compare June 25, 2024 10:20
@BelSasha BelSasha requested a review from jlewitt1 June 25, 2024 12:49
@BelSasha BelSasha requested a review from jlewitt1 June 26, 2024 08:34
@BelSasha BelSasha merged commit f397b6d into main Jun 26, 2024
12 checks passed
@BelSasha BelSasha deleted the sb/set_cluster_log_level branch June 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewitt1 jlewitt1 Awaiting requested review from jlewitt1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BelSasha @jlewitt1