-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new css parser - postcss #1458
Conversation
|
} | ||
getSelectors(ast.stylesheet); | ||
const mediaFeatures = css | ||
.findAll(newAst, (node) => node.type === 'MediaFeature') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly some further optimizations we could even make here by using the css.walk
method to only traverse the AST once (rather than twice like I assume findAll
is doing)
packages/rrweb-snapshot/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "rrweb-snapshot", | |||
"version": "2.0.0-alpha.13", | |||
"version": "2.0.0-alpha.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be 13
?
This is great and something I thought we might get to 'some day' after the recent fixes to css.ts. Would you be able to post a before/after of the built file sizes from this change; i.e.
One of the reasons css.ts was ported over was so that we could tree shake it a bit. |
Something isn't right here because I'm getting the same values when running
Before
After
|
In a significant update here I moved to using This massively simplifies the I've moved around some test files to better separate concerns. Some of the tests were "testing the framework" given they had been copied over from https://github.com/reworkcss/css/blob/master/test/parse.js. I removed any that were no longer relevant but left any of the cases added in https://github.com/rrweb-io/rrweb/pull/1440/files#diff-ca07555d1c1965f9c7ef3b5df3772a19953138b8eac62deb7786e549b25b455d as we know they've specifically broken in the past and we would like to avoid breaking them in the future |
Super! What sort of filesize numbers are there with the |
Sorry @eoghanmurray, probably wasn't clear but I updated my earlier comment with latest build numbers having run
|
@@ -9,6 +9,9 @@ import { | |||
} from './types'; | |||
import { isElement, Mirror, isNodeMetaEqual } from './utils'; | |||
|
|||
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-var-requires | |||
const postcss = require('postcss'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the various import methods, but feel this needs a bit of an explanation as to why you are doing it this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing tests to fail with require is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it that we need a typescript version of https://github.com/giuseppeg/postcss-pseudo-classes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This require business might be fixed with this PR: #1033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up @Juice10. I've been meaning to get back to this PR but have had some vacation recently. The good news is that this seems to have resolved all known CSS issues for us. I can hold off until the Vite changes are merged if that is imminent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daibhin, PR has been merged, although what you have done (replacing require by import) seems perfectly good
Hopefully the following doesn't derail the conversation, and even if we go ahead with the following, that doesn't detract from the worth of the current PR... So okay I just had a thought; all this CSS processing is on the replay side, right? === edit: I've drafted this up in #1480 |
Rebase or merge of master needed: there is a new test in #1481 which adds coverage to the css parser; hopefully it will pass (or fail) as-is without having to modify the test itself. |
Also re. rrweb-snapshot/test/rebuild.test.ts if you revert the whitespace changes to the expected css, you could instead cherry-pick the following commit which should do loose matching by ignoring whitespace and semicolon: |
Let me know if you wish me to execute the above two for you. |
@eoghanmurray cleaned up the whitespacing but bringing in the commit you mentioned. Also rebased to include the new test (it passed without changes). The current failing test seems unrelated but perhaps you can run it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly approve but have a few questions before merging.
}, | ||
}; | ||
|
||
// Adapted from https://github.com/giuseppeg/postcss-pseudo-classes/blob/master/index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, and I think I questioned somewhere whether we needed to import this.
I'm having some doubts now though, as just notice the following is possible with that plugin:
restrictTo: ['hover'],
did you consider that?
This approach of copying over a subset of the code has it's attractions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered adding the package but thought it easier just to copy the code. When I inlined it there were a bunch of options we didn't really need e.g. restrictTo
so just simplified the whole thing down. We can always go back and add the original in future, but I chose to go with the simpler (no import / no extra options) until we knew if we needed any more
value: val ? trim(val[0]).replace(commentre, '') : '', | ||
}); | ||
selectorParts.forEach(function (selectorPart) { | ||
const pseudos = selectorPart.match(/::?([^:]+)/g); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could possibly be more specific and include the hover
string here given we know that's what we will be matching against
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in that's the only one we need to support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually finds all pseudo elements on a selector, not just the hover. I simplified a different regex down in https://github.com/rrweb-io/rrweb/pull/1458/files#diff-8561a438ce9ce73d7e38ce75f7971111e91ea0365bf4588a82620655d8fc8e14R55
@Juice10 thanks for fixing up the imports. Do you know if the failing test is related to my changes somehow? |
Example: FAIL test/document-nodejs.test.ts > RRDocument for nodejs environment > RRDocument API > querySelectorAll TypeError: e[api] is not a function ❯ byTag ../../node_modules/nwsapi/src/nwsapi.js:390:37 ❯ Array.<anonymous> ../../node_modules/nwsapi/src/nwsapi.js:327:113 ❯ collect ../../node_modules/nwsapi/src/nwsapi.js:1578:32 ❯ Object._querySelectorAll [as select] ../../node_modules/nwsapi/src/nwsapi.js:1533:36 ❯ RRDocument.querySelectorAll src/document-nodejs.ts:96:24
@daibhin failing test was for 2872d0e was due to an upgraded package, thats fixed now (by locking the package version). The failure for c7153b7 seems to be due to jest being extended where we switched over to vitest. I just fixed that issue, but it looks like a chunk of the :hover tests are failing (you'll see that soon for 9df9946 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, and is so much easier to adapt!
rrweb-snapshot
parses stylesheets to adapt the CSS for playbackIn certain cases the parsing wasn't always correct:
PostHog/posthog#21427
#1379
Which led to improved CSS selector efforts first included in
[email protected]
(#1401)Sadly this caused playback issues that consumed 100% CPU and froze playback
![profiler](https://private-user-images.githubusercontent.com/6685876/325331813-ce216f8d-6b51-4d45-a878-54543e85a24b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NDA0OTksIm5iZiI6MTcxOTY0MDE5OSwicGF0aCI6Ii82Njg1ODc2LzMyNTMzMTgxMy1jZTIxNmY4ZC02YjUxLTRkNDUtYTg3OC01NDU0M2U4NWEyNGIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjlUMDU0OTU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODNiZGNiZGRlZTBkM2QxMWFiYTBhOTg0NTY1MWEzZDAxYjdlYTRhMTlkMzZmZjAzZTJmYTNjMzlmYzg1M2Q4MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.sI58JFZ65msiBo3waI-yXtF2IEizTXI1kN96Q2hvmm8)
PostHog/posthog#21791
CSS parsing is performed in the https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb-snapshot/src/css.ts which was pulled from https://github.com/reworkcss/css (which hasn't been updated in over 3 years)
I propose moving to https://github.com/csstree/csstree which creates an actual AST which can be used to effectively debug via https://astexplorer.net
I couldn't figure out some import issues in the
test/integration.test.ts
All
test/css.test.ts
tests still pass which confirms this is as good as the trickiest cases previously handled without any of the slowness introduced in #1401