Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make web-based widgets default #15913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

linev
Copy link
Member

@linev linev commented Jun 24, 2024

Following widgets will be web-based by default:

  1. TCanvas
  2. TBrowser
  3. TTreeViewer
  4. TGeomPainter

Type of all these widgets can be configured via rootrc file:

# As options for Canvas.Name, ROOT provides TWebCanvas and the legacy TRootCanvas.
Canvas.Name:                TWebCanvas

# Type of Browser: TRootBrowser or TRootBrowserLite or ROOT::RWebBrowserImp
Browser.Name:                ROOT::RWebBrowserImp

# Type of geometry painter: root or web
GeomPainter.Name:            web

# Type of tree viewer: TTreeViewer or RTreeViewer
TreeViewer.Name:             RTreeViewer

Any of these settings can be adjusted in local .rootrc file.

One can provide special config for web-based fit panel.
For the moment TH1::FitPanel() always starts classical GUI and there is no configurable plugin for that.
The only problem - web-based fit panel was not tested for long time.

If no any --web arguments provided,
use web-based RBrowser
Disable it when --web=off specified.
Let configure default kind of geometry painter with
GeomPainter.Name parameter in rootrc file.
Copy link

Test Results

    13 files      13 suites   3d 0h 17m 0s ⏱️
 2 646 tests  2 645 ✅ 0 💤 1 ❌
32 580 runs  32 579 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 9bddf5d.

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - NOT to be backported to 6.32.
Thanks @linev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants