Add PageIndicatorView2 to use with ViewPager2 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romandanylyk it will be cool to have this in the lib |
|
Merge this pls >>> |
|
👍 |
Ironthighs
suggested changes
Nov 11, 2020
| return; | ||
| } | ||
|
|
||
| setObserver = new RecyclerView.AdapterDataObserver() { |
There was a problem hiding this comment.
Should have other overrides to work with Android's AdapterListUpdateCallback.
override fun onItemRangeInserted(positionStart: Int, itemCount: Int) is important because without it, there are cases where the page indicator view won't display when it should. Same with implementing override fun onItemRangeChanged(positionStart: Int, itemCount: Int).
| startIdleRunnable(); | ||
| } | ||
|
|
||
| pageChangeCallback = new ViewPager2.OnPageChangeCallback() { |
There was a problem hiding this comment.
Missing important other override: fun onPageSelected(position: Int)
This override should call onPageSelect(position: Int) which is currently just going unused in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #115
I added a PageIndicatorView2 class that works well with ViewPager2.