Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell Check #275

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Spell Check #275

merged 5 commits into from
Jun 21, 2024

Conversation

weilirs
Copy link
Collaborator

@weilirs weilirs commented Jun 12, 2024

@weilirs
Copy link
Collaborator Author

weilirs commented Jun 12, 2024

The logging statements are working as expected but the spell check is not, any help?
Thanks!

@weilirs weilirs marked this pull request as ready for review June 13, 2024 13:58
@weilirs
Copy link
Collaborator Author

weilirs commented Jun 13, 2024

Quit and restart the app version now working. Ideally, after saving the spellcheck config it should take effect but for some reason now it is not.

samlhuillier
samlhuillier approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@samlhuillier samlhuillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@samlhuillier samlhuillier merged commit 9ddf141 into reorproject:main Jun 21, 2024
0 of 4 checks passed
@weilirs weilirs deleted the spellcheck branch June 24, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlhuillier samlhuillier samlhuillier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weilirs @samlhuillier