tests/ssx/single_sharded: fix -c1 and correct test file name #20152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtanov
force-pushed
the
ssx-single-sharded-test-fixup
branch
from
0e2334f
to
3c50f99
Compare
|
/dt |
|
/dt |
bashtanov
force-pushed
the
ssx-single-sharded-test-fixup
branch
from
3c50f99
to
4e8b69d
Compare
|
test failure unrelated |
ztlpn
reviewed
Jun 28, 2024
| @@ -80,7 +80,7 @@ struct caller { | |||
|
|
|||
| SEASTAR_THREAD_TEST_CASE(single_sharded) { | |||
| ss::shard_id the_shard = ss::smp::count - 1; | |||
| ss::shard_id wrong_shard = std::max(ss::shard_id{0}, the_shard - 1); | |||
| ss::shard_id wrong_shard = ss::smp::count == 1 ? 0 : the_shard - 1; | |||
There was a problem hiding this comment.
but if we run with -c1, there is no wrong shard, right? So I guess it would be more obvious if the part of the test requiring several shards would be clearly encapsulated in a code block (or maybe even a separate test) and wrong_shard would be declared there
There was a problem hiding this comment.
Can you think of an existing test that requires multiple shards? What does it do if there is only one shard?
There was a problem hiding this comment.
I think its ok to assume a minimum shard count in tests, just have an assert in the test, something like
BOOST_REQUIRE_GT(ss::smp::count, 1)
There are tests in the tree that does this, better to assert out than a segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsigned overflow prevented this test from running with -c1.
Test file name did not have _test suffix.
Backports Required
Release Notes