[v24.1.x] Always use the latest configuration for followers metadata #20148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed comment mentioning that we should add applying snapshot to stm as this is already being done Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 2f287e2)
When install snapshot request in processed by the follower it may not always replace the follower log content. If the snapshot last included offset is smaller than the follower dirty offset the follower should prefix truncate all the data up to the snapshot last included offset but keep all the entries which offset is greater than snapshot last included offset. Fixed the update of follower metadata state as it was always using the snapshot configuration instead the latest from the configuration manager. Fixes: #core-internal/issues/1310 Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit c69709f)
When install snapshot request is received by the current leader it must unconditionally step down. This is the same behavior as in the case of receiving an append entries request. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 571aa19)
When install snapshot request is delayed and deliver to the node after it already made progress it can not lead to state inconsistencies. Added test validating handing of delayed `install_snapshot` requests. The test is validating behavior of both follower and the leader. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit e73aa28)
(cherry picked from commit b52b4c3)
Support std::error_code, raft::errc, cluster::errc and bool, both individually and as part of a result<..., ...> (cherry picked from commit 94e99f0)
That's mostly for later use in raft_fixture::retry_with_leader (cherry picked from commit 07e714f)
As part of deprecating simple_raft_fixture in favour of raft_fixture, making id_allocator_stm_test to use the latter. (cherry picked from commit 3821433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #19964