[rpk connect] Add .rp_connect_ref to tie rpk to certain connect version #20141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackietung-redpanda
requested review from
ivotron
and removed request for
a team
| @@ -247,6 +247,7 @@ vbuild/ | |||
| /.vtools.yml | |||
| /vtools | |||
| /benthos | |||
| /connect | |||
There was a problem hiding this comment.
vtools logic will check out connect code at connect/, so need to add to .gitignore.
Leaving benthos/ ignore in place... just in case - not worth any potential trouble to remove that at this point.
|
cc @Jeffail FYI this introduces a marker file that links a certain version of RPK to a certain version of |
jackietung-redpanda
changed the title
ivotron
approved these changes
Jun 25, 2024
|
Aborting this PR. We will track rp connect ref inline within vtools / packaging code instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
.rp_connect_reffile denotes the specific code commit fromredpanda-data/connectthatrpkshould be bundled with during packaging. This PR must merge before this vtools PR.Backports Required
Release Notes