[v24.1.x] Transforms: Fix deploy-time timequery bug #20139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default behavior is for transforms to start processing input from an offset equivalent to "the latest committed offset at deploy time". However, in situations where no records are committed between the moment the transform was deployed and the moment the transform starts, the timequery servicing this logic returns an empty result, which is handled by returning offset::min, which signals the transform to begin processing at the beginning of the topic. This commit adjusts the logic in source::offset_at_timestamp to return nullopt for an empty timequery result, and the handling of that nullopt to resolve the transform start offset to latest. Signed-off-by: Oren Leiman <[email protected]> (cherry picked from commit 2401fa3)
Specifically in situations where no records are produced between deploy time and start time. Signed-off-by: Oren Leiman <[email protected]> (cherry picked from commit 0f49b21)
|
/ci-repeat 1 |
oleiman
requested review from
a team and
pgellert
and removed request for
a team
|
Conflict was some tests in |
michael-redpanda
approved these changes
Jun 25, 2024
pgellert
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #20127