-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-4279] Wire up schema_registry/json #20136
Merged
andijcr
merged 3 commits into
redpanda-data:dev
from
andijcr:fix/core-4435/schema_registry_backward_forward
Jun 27, 2024
Merged
[CORE-4279] Wire up schema_registry/json #20136
andijcr
merged 3 commits into
redpanda-data:dev
from
andijcr:fix/core-4435/schema_registry_backward_forward
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-redpanda
previously approved these changes
Jun 25, 2024
BenPope
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put a compatibility test (such as from the demo) into ducktape, along with something like this:
index fbb6b972b2..cc5de47f7d 100644
--- a/src/v/pandaproxy/schema_registry/sharded_store.cc
+++ b/src/v/pandaproxy/schema_registry/sharded_store.cc
@@ -686,12 +686,18 @@ ss::future<bool> sharded_store::is_compatible(
co_return true;
}
- // Currently support PROTOBUF, AVRO
- if (
- new_schema.type() != schema_type::avro
- && new_schema.type() != schema_type::protobuf) {
+ // Currently support JSON, PROTOBUF, AVRO
+ if (![type = new_schema.type()] {
+ switch (type) {
+ case schema_type::avro:
+ case schema_type::protobuf:
+ case schema_type::json:
+ return true;
+ }
+ return false;
+ }()) {
throw as_exception(invalid_schema_type(new_schema.type()));
- }
+ };
// if transitive, search all, otherwise seach forwards from version
if (
accept schema_type::json in is_compatible
…version to allow in the next commit to use a different schema type
add a JSON dataset to test_post_compatibility_subject_version
393bff2
to
715a0df
Compare
BenPope
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
michael-redpanda
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up schema_registry support for json schema.
this pr enables json schema inputs and adds a ducktape test for json schema compatibility
Backports Required
Release Notes