build: bazel foundation #19946
Draft
build: bazel foundation #19946
+7,552
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Useful for passing in BOOST_TEST_MODULE=foo to add a main(). Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
The config option `--@seastar//:numa=True` didn't read very intuitively, so changed it to `numactl`. Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
rockwotj
reviewed
Jun 25, 2024
Signed-off-by: Noah Watkins <[email protected]>
rockwotj
reviewed
Jun 26, 2024
The second --copt is an argument to the first (-mllvm), but bazel doesn't seem to accept various forms of combining these. So instead put them on the same line to highlight their relationship, and rely on what we believe to be bazel retaining the ordering. Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Avro .cc files include "header.h" without the "avro/" path prefix. We want to expose the parent of "avro" so that users of the library include with the expected "avro/header.h" path, but don't want to expose the non-prefixed path. The way to hide this would be to add `-I<path>` to `copts`, but such a solution is ellusive (the recommended `-Iexternal/...` doesn't seem to work as expected with bazel modules). Anyway, the work around in this PR stages a copy of all the headers into a separate directory and uses that as a set of private headers added to `srcs`. Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Redpanda now only uses OpenSSL (including Seastar) for crypto stuff, which means that we do not need gnutls, nettle, gmp, or cryptopp. Signed-off-by: Noah Watkins <[email protected]>
|
this is pretty cool. |
Signed-off-by: Noah Watkins <[email protected]>
Found by buildifier linter. Signed-off-by: Noah Watkins <[email protected]>
The glob wasn't used because all of the files were explicitly listed.
Signed-off-by: Noah Watkins <[email protected]>
Checks for bazelisk, and in the future, could download bazelisk automatically. Signed-off-by: Noah Watkins <[email protected]>
This isn't ideal, but it sounds like it really only affects the ability to cache *.pyc files. In our case, we have about a grand total of 3 or 4 files we compile with Python so I'm not sure it's worth the headache right of figuring out a different way to deal with this. bazelbuild/rules_python#1169 Useful for docker builds that require extra effort to use in a non-root context. Signed-off-by: Noah Watkins <[email protected]>
It's weird, I get it. Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel build foundation.
https://redpandadata.atlassian.net/wiki/spaces/~96716674/pages/714670307/Bazel
Backports Required
Release Notes