[wip] cloud_storage: change remote naming scheme #19934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
wip-remote-labels
branch
2 times, most recently
from
2f42518
to
71b2dae
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
from
71b2dae
to
15bbd2a
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
2 times, most recently
from
303b8f4
to
ed82b8a
Compare
|
/ci-repeat |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad4-415b-87ef-b7442a2b84bd: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad1-459d-8121-7045807b61f4: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad5-4c8f-90ba-ba291ac3392b: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad8-46ef-9e52-49a04ffbb303: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7f-492f-9287-a0e4978af2ca: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7c-4f59-b681-6ea232b95745: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7b-4a0e-a8fc-d555002dfcc9: new failures in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee78-4d55-80f3-d14d3aa159be: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad4-415b-87ef-b7442a2b84bd ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-2ad1-459d-8121-7045807b61f4 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7f-492f-9287-a0e4978af2ca ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7c-4f59-b681-6ea232b95745 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50495#01903704-ee7b-4a0e-a8fc-d555002dfcc9 |
andrwng
force-pushed
the
wip-remote-labels
branch
from
ed82b8a
to
a375e4a
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
from
a375e4a
to
15b7f5e
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
from
15b7f5e
to
ebd7763
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
from
ebd7763
to
5f6f872
Compare
|
/ci-repeat |
andrwng
force-pushed
the
wip-remote-labels
branch
2 times, most recently
from
d380716
to
6a8ebbd
Compare
|
/ci-repeat |
With the naming scheme changing, adds some utilities for generating object paths or parts of paths (useful for listing objects).
Callers are now required to provide a path, which helps encourage callers to think about using a path provider.
Adds an expectation for the new labeled list_object call performed by topic recovery.
This is no longer used.
It's generally unimportant, and most admin endpoints don't require thie field (they select one for the caller).
BucketViews are typically used to examine the state of a bucket in the context of a test. With objects proceeding to be include a given cluster's UUID, this updates the view to know how to interpret the UUID.
For tests
Automated topic recovery performs a list bucket operation to discover what topics can be restored. This commit updates this to account for topic manifests labeled with the cluster UUID.
In several test cases, the test needs to know about the previous cluster UUID to know to filter only objects for that cluster.
The prefix the test ignores is now a full UUID (36 chars) rather than a hash (8 chars).
The bucket view supports a cluster UUID filter to target objects that include a cluster UUID label in their path. This isn't used for cluster metadata, which expects to see metadata for multiple cluster UUIDs.
Objects from older versions will not includ the cluster UUID in their paths, so update the test's BucketVIew to not filter.
The test examines multiple clusters, so the bucket view shouldn't filter out other clusters' metadata.
Changes partition manifest paths to: <cluster_uuid>/meta/<ns>/<topic>/<partition>_<revision>/manifest.bin This means that it's easier to distinguish partition manifests over segments when when prefixing with <cluster_uuid>/meta/<ns>/<topic>/<partition>, as done by the purger. Changes topic manifest paths to: meta/<ns>/<topic>/<cluster_uuid>/topic_manifest.bin This means it's easier to list all topic manifests, by listing under meta/, as we may do for automated topic recovery.
Now that we first look for labeled manifests in automated topic recovery, there's an extra list request with prefix meta/kafka.
This will be useful in upgrade tests that use quiesce uploads, coming from versions that don't support remote labels.
andrwng
force-pushed
the
wip-remote-labels
branch
from
6a8ebbd
to
d538e2d
Compare
|
/ci-repeat |
|
/cdt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level PR breakdown, but will break this into smaller PRs:
New primitives:
Plumbing:
Cleanup:
Backports Required
Release Notes