Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce mandatory trailing comma and fix all violations #5640

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Jun 22, 2024

2 Warnings
⚠️ Big PR
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.66s vs 0.67s on main (1% faster)
📖 Linting Alamofire with this PR took 0.85s vs 0.88s on main (3% faster)
📖 Linting Brave with this PR took 5.14s vs 5.3s on main (3% faster)
📖 Linting DuckDuckGo with this PR took 2.88s vs 2.86s on main (0% slower)
📖 Linting Firefox with this PR took 8.24s vs 8.74s on main (5% faster)
📖 Linting Kickstarter with this PR took 7.19s vs 7.15s on main (0% slower)
📖 Linting Moya with this PR took 0.4s vs 0.41s on main (2% faster)
📖 Linting NetNewsWire with this PR took 1.83s vs 1.84s on main (0% faster)
📖 Linting Nimble with this PR took 0.56s vs 0.56s on main (0% slower)
📖 Linting PocketCasts with this PR took 6.28s vs 6.2s on main (1% slower)
📖 Linting Quick with this PR took 0.33s vs 0.33s on main (0% slower)
📖 Linting Realm with this PR took 3.66s vs 3.45s on main (6% slower)
📖 Linting Sourcery with this PR took 1.68s vs 1.75s on main (4% faster)
📖 Linting Swift with this PR took 3.2s vs 3.07s on main (4% slower)
📖 Linting VLC with this PR took 0.89s vs 0.89s on main (0% slower)
📖 Linting Wire with this PR took 12.07s vs 12.5s on main (3% faster)
📖 Linting WordPress with this PR took 8.93s vs 9.12s on main (2% faster)

Here's an example of your CHANGELOG entry:

* Enforce mandatory trailing comma and fix all violations.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Copy link
Collaborator

@mildm8nnered mildm8nnered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@SimplyDanny SimplyDanny enabled auto-merge (squash) June 28, 2024 05:22
@SimplyDanny SimplyDanny merged commit c810459 into realm:main Jun 28, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the enable-trailing-comma branch June 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants