Add update checker #5613
Draft
Add update checker #5613
+128
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
reviewed
Jun 16, 2024
| var request = URLRequest(url: url) | ||
| request.setValue("SwiftLint", forHTTPHeaderField: "User-Agent") | ||
| request.setValue("application/vnd.github.v3+json", forHTTPHeaderField: "Accept") | ||
| let semaphore = DispatchSemaphore(value: 0) |
There was a problem hiding this comment.
Can we go with some Swift Concurrency magic here instead? I assume the whole method chain can be async.
| let minor = components.dropFirst(1).first ?? 0 | ||
| let patch = components.dropFirst(2).first ?? 0 | ||
| return [major, minor, patch] | ||
| } |
There was a problem hiding this comment.
There is a similar (or equal) implementation for SwiftVersion. Can we somehow reduce them to just one? Something like VersionComparable with a default implementation that only relies on the underlying version string.
mildm8nnered
force-pushed
the
mildm8nnered-check-for-updates
branch
from
5017b0f
to
735f371
Compare
Here's an example of your CHANGELOG entry: * Add update checker.
[mildm8nnered](https://github.com/mildm8nnered)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
mildm8nnered
force-pushed
the
mildm8nnered-check-for-updates
branch
4 times, most recently
from
16ea749
to
e7bc567
Compare
mildm8nnered
force-pushed
the
mildm8nnered-check-for-updates
branch
from
6899365
to
a86b335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an update check facility to SwiftLint - addresses #5551
This has been added as a
--check-for-updatescommand line option to theversion,lint, andanalyzecommands.It can also be enabled via the configuration file, as
check_for_updates.Although the usefulness of an opt-in option is limited, at least this provides a good story for how users can keep their installs up to date. And it could easily be changed to opt-out either here or at some later date.
The update checker code is pretty closely based on Periphery's implementation, and should probably be credited in the source file.
The update check is performed after all other processing, so linting will never be delayed, and the code is completely synchronous, as we do not have to worry about blocking the main thread.
The messaging for a new version is:
A new version of SwiftLint is available: 0.51.1We currently do not print any messaging if the update check fails, which is probably wrong.