Fix superfluous disable command for custom rules #5546
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Fix superfluous disable command for custom rules.
[mildm8nnered](https://github.com/mildm8nnered)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
mildm8nnered
force-pushed
the
mildm8nnered-fix-superfluous-disable-command-for-custom-rules
branch
4 times, most recently
from
2aa98d0
to
ceb3969
Compare
mildm8nnered
force-pushed
the
mildm8nnered-fix-superfluous-disable-command-for-custom-rules
branch
from
ceb3969
to
344f376
Compare
mildm8nnered
force-pushed
the
mildm8nnered-fix-superfluous-disable-command-for-custom-rules
branch
5 times, most recently
from
6dfd584
to
255e35b
Compare
…the top of the file.
mildm8nnered
force-pushed
the
mildm8nnered-fix-superfluous-disable-command-for-custom-rules
branch
from
255e35b
to
733e16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a work in progress, so please ignore for now.
This is redo of #4755 (which was reverted in #5336).
I took the original changes from #4755 and worked from there. The changes I've made on top of the original PR can be seen at mildm8nnered/SwiftLint@mildm8nnered-marcelos-changes-back...mildm8nnered:SwiftLint:mildm8nnered-fix-superfluous-disable-command-for-custom-rules
I thought this was good, but
custom_rulesnow seems to be picking up issues that it didn't see before (fatalError), and there were some issues with superfluous triggering in some tests that I was not expecting either, so I think more work is required here.