Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: third card item's right border not showing #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliejgiles
Copy link

Issue:

Outer right carousel item has its border hidden at certain screen widths:
image

Cause
When an odd number of cards are used in the carousel, the sum of all card widths and spacing exceeds the container so the outer right border of the last item is hidden due to the container's overflow:hidden css property (https://github.com/rcbyr/keen-slider/blob/master/src/keen-slider.scss)

For example, by overriding keen-slider 's css to overflow: visible, the border will show up again.

Fix
Round down the card size where it is not a whole number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant