Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

use for each for streaming jobs #276

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roelschr
Copy link
Contributor

Why? 馃摉

Replace me for a cool overview of why this PR is being created. You can
refer to the Jira task or Github issue here too. Never forget to put the
tag of a related Jira task in the title.

What? 馃敡

Replace me for a detailed explanation of what is being modified.
Want to add some awesome bullet points?

  • First changes;
  • Second changes;
  • ...

How about some cool checkboxes?

  • First changes;
  • Second changes;
  • ...

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Release

How everything was tested? 馃搹

Have you achieved all the acceptance criteria? How?
Is there any alternative flow in the testing process that you want to describe?

Checklist

  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • New and existing unit tests pass locally with my changes;
  • Add labels to distinguish the type of pull request. Available labels are bug, enhancement, feature, and review.

Attention Points 鈿狅笍

Replace me for what the reviewer will need to pay attention to in the PR or just to cover any concerns after the merge.

@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant