Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VitePluginUsage.vue #17316

Closed
wants to merge 1 commit into from
Closed

Conversation

hinogi
Copy link

@hinogi hinogi commented Jun 24, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@yusufkandemir
Copy link
Member

You didn't share the point of this PR. But, from what I can see it's a recommendation for a better organization. However, create-vite creates the style file in src/style.css. create-vue creates the style files in src/assets/.... Neither uses Sass as Vite recommends using modern CSS instead. This change would not align with either of the templates, so I will close this PR. Thanks for your time and understanding.

@hinogi
Copy link
Author

hinogi commented Jun 27, 2024

The file ending was not the point, but if it is .sass it is not where the article shows it would be not is the name correct.

@yusufkandemir
Copy link
Member

Not sure if I understand anything, but I will try my best. Sass was a side point I mentioned. They either place styles in src/ or src/assets, so creating it in src/css doesn't align with either of the templates.

@hinogi
Copy link
Author

hinogi commented Jun 28, 2024

image
This was my point.

@hinogi
Copy link
Author

hinogi commented Jun 28, 2024

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants