Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): All components to use SASS variable for font size #17264 #17274

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ekamphuis82
Copy link

@ekamphuis82 ekamphuis82 commented Jun 10, 2024

Resolves #17264

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@mstroeve
Copy link

mstroeve commented Jun 20, 2024

@yusufkandemir as this is our first PR in this project can you give us feedback regarding the correct usage of guide lines in this PR?

@yusufkandemir
Copy link
Member

@mstroeve with a broad look, things look fine. We will need to review it to ensure it's ready to get merged. We couldn't find enough time to review it, yet. Thanks for your understanding and the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All components to use SASS variable for font size
3 participants