Histogram save load #4537
Open
Histogram save load #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzfc
reviewed
Jun 27, 2024
Comment on lines
+254
to
+262
|
|
||
| // test persistence | ||
| let dir = tempfile::Builder::new() | ||
| .prefix("histogram_dir") | ||
| .tempdir() | ||
| .unwrap(); | ||
| histogram.save(&dir).unwrap(); | ||
| let histogram = Histogram::<f64>::load(&dir).unwrap(); | ||
|
|
There was a problem hiding this comment.
I suggest to not to mix things under the test. Instead, split into two parts:
In the first, run the old test without saving/loding.
In the second, do load/save and compare histograms using assert_eq!().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of on-disk-payload-feature.
For the on-disk numeric index, it was decided that the histogram would be still on RAM because it's pretty small. But we need persistence anyway to avoid a full scan while loading.
This PR adds save-load for histogram and use it in histogram unit test.