Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New and Optimized Regex Search Test Functions. #1937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brandenvs
Copy link

@brandenvs brandenvs commented May 30, 2024

New functions include:

test_regex_search_case_insensitive()
test_regex_search_multiple_groups()
test_regex_search_group_out_of_range()
test_regex_search_group_out_of_range()

Motivation for additional functions

The test functions present did not consider whether we were testing a case-insensitive or case-sensitive field/string. This contribution has also been amended to include the testing of multiple groups. Then, I added a test function for scenarios where a group is out of bounds and throws an IndexError.

Improved functions include:

test_regex_search()

Motivation for improvement

The test functions were redundant, so I combined the test_regex_search_no_match() with test_regex_search.

I hope you will consider my contribution.

Warm regards,
Branden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants