Fix spill over of ocean/and features in cartopy plots in case of geostationary full disc plot. #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 94.01% 93.98% -0.04%
==========================================
Files 92 86 -6
Lines 13836 13766 -70
==========================================
- Hits 13008 12938 -70
Misses 828 828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djhoese
reviewed
Jun 18, 2024
|
|
||
| # For geostationary full disc the boundary needs to be the actuall boundary of the earth disc otherwise | ||
| # when ocean or land features are added to the cartopy plot these spill over. | ||
| if "Geostationary Satellite" in crs.to_wkt(): |
There was a problem hiding this comment.
It would be great if this if block for geos was put into a separate function/method. Or at least invert the condition and put the much smaller else: block in the main if block and return immediately.
mraspaud
reviewed
Jun 18, 2024
| @@ -69,3 +70,70 @@ def __init__(self, | |||
| if self.bounds is not None: | |||
| x0, x1, y0, y1 = self.bounds | |||
| self.threshold = min(abs(x1 - x0), abs(y1 - y0)) / 100. | |||
|
|
|||
| # For geostationary full disc the boundary needs to be the actuall boundary of the earth disc otherwise | |||
There was a problem hiding this comment.
What if it's only part of the disc, but including some boundary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of geostationary full disc plots the boundary of the cartopy CRS needs to be the actual full disc otherwise ocean/land features spill over.
Since the
to_cartopy_crsmethod in pyresample uses a custom Projection class this is a hot fix using code from the CartopyGeostationaryclass.