Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenXLA-pin to Jun27 #7334

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Update OpenXLA-pin to Jun27 #7334

wants to merge 29 commits into from

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented Jun 24, 2024

Update OpenXLA-pin to Jun24

@JackCaoG
Copy link
Collaborator

error seems real


2024-06-24T18:04:47.4200857Z     In file included from external/xla/xla/client/client.cc:16:
2024-06-24T18:04:47.4202435Z     external/xla/xla/client/client.h:43:9: error: declaration of 'using XlaComputationInstance = struct xla::XlaComputationInstance' changes meaning of 'XlaComputationInstance' [-fpermissive]
2024-06-24T18:04:47.4203850Z        43 |   using XlaComputationInstance = XlaComputationInstance;
2024-06-24T18:04:47.4204474Z           |         ^~~~~~~~~~~~~~~~~~~~~~
2024-06-24T18:04:47.4205084Z     In file included from external/xla/xla/client/client.h:29,
2024-06-24T18:04:47.4205734Z                      from external/xla/xla/client/client.cc:16:
2024-06-24T18:04:47.4206925Z     external/xla/xla/service/service.h:116:8: note: 'XlaComputationInstance' declared here as 'struct xla::XlaComputationInstance'
2024-06-24T18:04:47.4207994Z       116 | struct XlaComputationInstance ***
2024-06-24T18:04:47.4208506Z           |        ^~~~~~~~~~~~~~~~~~~~~~
2024-06-24T18:04:47.4209159Z     INFO: Elapsed time: 1049.367s, Critical Path: 110.83s
2024-06-24T18:04:47.4210096Z     INFO: 17565 processes: 3704 remote cache hit, 9317 internal, 4544 local.

Can you rebase and fix this compilation error?

@ManfeiBai
Copy link
Collaborator Author

ManfeiBai commented Jun 28, 2024

error seems real


2024-06-24T18:04:47.4200857Z     In file included from external/xla/xla/client/client.cc:16:
2024-06-24T18:04:47.4202435Z     external/xla/xla/client/client.h:43:9: error: declaration of 'using XlaComputationInstance = struct xla::XlaComputationInstance' changes meaning of 'XlaComputationInstance' [-fpermissive]
2024-06-24T18:04:47.4203850Z        43 |   using XlaComputationInstance = XlaComputationInstance;
2024-06-24T18:04:47.4204474Z           |         ^~~~~~~~~~~~~~~~~~~~~~
2024-06-24T18:04:47.4205084Z     In file included from external/xla/xla/client/client.h:29,
2024-06-24T18:04:47.4205734Z                      from external/xla/xla/client/client.cc:16:
2024-06-24T18:04:47.4206925Z     external/xla/xla/service/service.h:116:8: note: 'XlaComputationInstance' declared here as 'struct xla::XlaComputationInstance'
2024-06-24T18:04:47.4207994Z       116 | struct XlaComputationInstance ***
2024-06-24T18:04:47.4208506Z           |        ^~~~~~~~~~~~~~~~~~~~~~
2024-06-24T18:04:47.4209159Z     INFO: Elapsed time: 1049.367s, Critical Path: 110.83s
2024-06-24T18:04:47.4210096Z     INFO: 17565 processes: 3704 remote cache hit, 9317 internal, 4544 local.

Can you rebase and fix this compilation error?

Thanks, this error has been fixed in openxla/xla@13e0739

would update pin to jun27 to include this fix

@ManfeiBai ManfeiBai changed the title Update OpenXLA-pin to Jun24 Update OpenXLA-pin to Jun27 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants