Overlap comms on backward pass #2117
Open
+159
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
dstaay-fb
force-pushed
the
export-D58220332
branch
from
46fa38d
to
9519360
Compare
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Jun 26, 2024
Summary: Pull Request resolved: pytorch#2117 Resolves issues around cuda streams / NCCL Deadlock with autograd. Basically create seperate streams per pipelined embedding arch. Differential Revision: D58220332
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
dstaay-fb
force-pushed
the
export-D58220332
branch
from
9519360
to
83df7c4
Compare
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Jun 26, 2024
Summary: Pull Request resolved: pytorch#2117 Resolves issues around cuda streams / NCCL Deadlock with autograd. Basically create seperate streams per pipelined embedding arch. Differential Revision: D58220332
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Jun 26, 2024
Summary: Pull Request resolved: pytorch#2117 Resolves issues around cuda streams / NCCL Deadlock with autograd. Basically create seperate streams per pipelined embedding arch. Differential Revision: D58220332
dstaay-fb
force-pushed
the
export-D58220332
branch
from
83df7c4
to
57c6235
Compare
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Jun 26, 2024
Summary: Pull Request resolved: pytorch#2117 Resolves issues around cuda streams / NCCL Deadlock with autograd. Basically create seperate streams per pipelined embedding arch. Differential Revision: D58220332
dstaay-fb
force-pushed
the
export-D58220332
branch
from
57c6235
to
28ff399
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
Summary: Pull Request resolved: pytorch#2117 Resolves issues around cuda streams / NCCL Deadlock with autograd. Basically create seperate streams per pipelined embedding arch. Reviewed By: sarckk Differential Revision: D58220332
|
This pull request was exported from Phabricator. Differential Revision: D58220332 |
dstaay-fb
force-pushed
the
export-D58220332
branch
from
28ff399
to
5e09f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves issues around cuda streams / NCCL Deadlock with autograd.
Basically create seperate streams per pipelined embedding arch.
Differential Revision: D58220332