Support compute_uinit in coreml backend when calling ct.convert #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4059
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d088e42 with merge base f538eae ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58981934 |
|
I think
|
YifanShenSZ
approved these changes
Jun 25, 2024
…rch#4059) Summary: Pull Request resolved: pytorch#4059 It seems currently the compute unit value set in https://www.internalfb.com/code/fbsource/fbcode/executorch/examples/models/llama2/lib/partitioner_lib.py?lines=74 is not used during the convert, adding the support in this diff. However to my surprise, the model name in the actual ios instrument result has the right suffix (see the image below), I couldn't find anywhere in the code how this is set and I have no way to validate if it's just part of the name or it's indeed set correctly through another path. I'll abandon this diff if it's not needed actually... {F1718372833} Reviewed By: cccclai Differential Revision: D58981934
|
This pull request was exported from Phabricator. Differential Revision: D58981934 |
seayoung1112
force-pushed
the
export-D58981934
branch
from
c2110f7
to
d088e42
Compare
cccclai
approved these changes
Jun 26, 2024
|
This pull request has been merged in 85cf584. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It seems currently the compute unit value set in executorch/examples/models/llama2/lib/partitioner_lib.py?lines=74 is not used during the convert, adding the support in this change.
However to my surprise, the model name in the actual ios instrument result has the right suffix (see the image below), I couldn't find anywhere in the code how this is set and I have no way to validate if it's just part of the name or it's indeed set correctly through another path. I'll abandon this diff if it's not needed actually...
{F1718372833}
Differential Revision: D58981934