Do not link quantized ops libraries into portable_lib by default #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: CMake options will decide whether portable_lib should link quantized ops libraries (`quantized_ops`, `quantized_ops_aot_lib`). This fix the issue where we build `portable_lib` but doesn't have `EXECUTORCH_BUILD_KERNELS_QUANTIZED(_AOT)` set to `ON`. Test Plan: ``` cmake -DEXECUTORCH_BUILD_PYBIND=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=OFF -Bcmake-out . cmake --build . ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4039
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c488da9 with merge base 39e17e4 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
dbort
reviewed
Jun 25, 2024
| @@ -679,6 +677,9 @@ if(EXECUTORCH_BUILD_PYBIND) | |||
| if(EXECUTORCH_BUILD_KERNELS_QUANTIZED) | |||
| target_link_options_shared_lib(quantized_ops_lib) | |||
| list(APPEND _dep_libs quantized_kernels quantized_ops_lib) | |||
| if(TARGET quantized_ops_aot_lib) | |||
| list(APPEND _dep_libs quantized_kernels quantized_ops_aot_lib) | |||
There was a problem hiding this comment.
This will add quantized_kernels to the list twice, since it was already added by line 681
| @@ -656,8 +656,6 @@ if(EXECUTORCH_BUILD_PYBIND) | |||
| etdump | |||
| executorch | |||
| extension_data_loader | |||
| portable_ops_lib | |||
There was a problem hiding this comment.
Is this added as a transitive dep somewhere, or are you removing the portable ops altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CMake options will decide whether portable_lib should link quantized ops libraries (
quantized_ops,quantized_ops_aot_lib).This fix the issue where we build
portable_libbut doesn't haveEXECUTORCH_BUILD_KERNELS_QUANTIZED(_AOT)set toON.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: