Propagate is_async_generator down to overloads #17435
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/leaderboard.py:114: error: Overloaded function implementation cannot produce return type of signature 1 [misc]
- steam/leaderboard.py:114: error: Overloaded function implementation cannot produce return type of signature 2 [misc]
|
|
Primer diff shows only one false positive removed. That error was caused exactly by mistreatment fixed in this PR. |
|
Thanks for the PR! Since this changes the meanings of annotations, we should probably open a thread on https://discuss.python.org/c/typing/32 (e.g. pyright currently behaves the same as mypy) |
|
This is being discussed at https://discuss.python.org/t/overloads-of-async-generators-inconsistent-coroutine-wrapping/56665. |
|
I'm marking this draft for now, because Eric Traut seems to be against this idea, let's wait for some decision to settle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17340
When an overloaded definition is checked, overloads usually have a trivial body. As a result, the return type of async overloads is wrapped with
Coroutine, while the implementation is not - all this happens during semanal based solely onyieldpresence.When such situation is encountered, we should unwrap the return type and mark the functions as async generators.