Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branding: improve IO resilience #2869

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Branding: improve IO resilience #2869

wants to merge 9 commits into from

Commits on Dec 28, 2023

  1. Branding: remove redundant error handling 

    If an error occurs during event fetch, the operation will now fail
rather than skip the event or return an empty result.

Skipping events may cause the branding to reset or change unexpectedly,
which is not desired. If the bot cannot fetch all events, it should
leave the existing branding assets intact.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ce7e2fd View commit details
    Browse the repository at this point in the history

  2. Branding: fail if no event is active 

    If the bot cannot find an active event, it will try to find the
fallback event. If the fallback event cannot be found either,
it will now raise an error.

This should be an exceptional state that cannot be recovered from.
Synchronisation should be retried once the event setup is corrected.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    872c656 View commit details
    Browse the repository at this point in the history

  3. Branding: handle errors in calendar refresh 

    The event fetch may now fail. We handle the error in the calendar
refresh command and present the user with the result.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    44bcfca View commit details
    Browse the repository at this point in the history

  4. Deps: add 'backoff'

    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    04f36e6 View commit details
    Browse the repository at this point in the history

  5. Branding: implement retry for server errors 

    Requests that fail due to a GitHub server error will now be retried.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6c914de View commit details
    Browse the repository at this point in the history

  6. Branding: do not invoke calendar after refresh 

    The bot will no longer automatically invoke the calendar view cmd
after a cache refresh, as the cache refresh may fail.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8d7ab36 View commit details
    Browse the repository at this point in the history

  7. Branding: pre-define retry decorator

    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    256d4cb View commit details
    Browse the repository at this point in the history

  8. Branding: disable jitter 

    No use for jitter in this case, as we don't make concurrent requests.
Deterministic delays make more sense.
    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5871218 View commit details
    Browse the repository at this point in the history

  9. Branding: remove redundant parentheses

    @kwzrd
    kwzrd committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9d0f8ff View commit details
    Browse the repository at this point in the history