Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic proxy per download #4486

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Jun 16, 2024

fix #3899

based on #4478 but not required here

work in progress, including some other changes like hot-reloading

@pep8speaks
Copy link

Hello @milahu! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:1: E265 block comment should start with '# '

Line 299:9: E306 expected 1 blank line before a nested definition, found 0
Line 314:13: E265 block comment should start with '# '
Line 324:13: E306 expected 1 blank line before a nested definition, found 0
Line 335:89: E501 line too long (94 > 88 characters)
Line 337:89: E501 line too long (106 > 88 characters)

Line 213:21: E265 block comment should start with '# '
Line 214:21: E265 block comment should start with '# '
Line 215:21: E265 block comment should start with '# '
Line 217:21: E265 block comment should start with '# '
Line 236:32: E713 test for membership should be 'not in'
Line 247:89: E501 line too long (96 > 88 characters)
Line 250:89: E501 line too long (123 > 88 characters)
Line 283:21: E265 block comment should start with '# '
Line 284:89: E501 line too long (91 > 88 characters)

Line 121:89: E501 line too long (96 > 88 characters)

Line 153:76: E711 comparison to None should be 'if cond is not None:'

Line 201:89: E501 line too long (98 > 88 characters)

Line 192:89: E501 line too long (92 > 88 characters)

Line 31:25: E261 at least two spaces before inline comment
Line 43:13: E265 block comment should start with '# '

Line 168:89: E501 line too long (98 > 88 characters)

Line 14:89: E501 line too long (93 > 88 characters)
Line 59:89: E501 line too long (94 > 88 characters)

We recommend to use black to automatically correct these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Per link (download) proxy config
2 participants