-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crypter & Downloader] Added knigavuhe.org #4480
base: develop
Are you sure you want to change the base?
Conversation
Hello @EnergoStalin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
We recommend to use black to automatically correct these files. Comment last updated at 2024-06-08 22:05:20 UTC |
__type__ = "downloader" | ||
__version__ = "0.1" | ||
__status__ = "testing" | ||
__pattern__ = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__pattern__
must not be surrounded by round brackets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done automatically by black due to line length > 88(89 to be exact). I guess linter will fail if i change that.
Sorry but one more thing: please issue the PR against the |
Also it suddenly stopped working now with |
Probably a solution would be something like: pyload/src/pyload/plugins/decrypters/MegaCoNzFolder.py Lines 34 to 44 in 9376854
|
downloader needed to conform filename i couldn't figure out a better way at a time
7279563
to
a341e05
Compare
Don't think it should be that big not bigger 2GB for sure. Will debug through mitmproxy to see if it actually should be this big. |
Ok it's broken because i renamed Hoster part. When adding S prefix again it works like before. Probably i guessed first time right you cant name it same way expecting to work. I couldn't figure out how to set filename for url from Solutions
|
This is fixing the issue but then it fails unable to resolve BookPlayer data in decrypter. |
Describe the changes
Add simple provider for https://knigavuhe.org so feeding url like this
https://knigavuhe.org/book/dopolnitelnye-istorii/
would download a book.S in SKnigavuhe states for
Storage
cause i suspect s3 backend judging by subdomain. It serves sole purpose - rewriting name without touching url. Couldn't figure out better way to do it.Additional references
Maybe i will add proper naming templates to it and more metadata resolving from page but for now it's all what i need.