Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YouTube itags #4465

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added YouTube itags #4465

wants to merge 2 commits into from

Conversation

m0n4
Copy link

@m0n4 m0n4 commented May 24, 2024

Describe the changes

Added YouTube video stream format codes.

Is this related to a problem?

Some Youtube itags were not listed, causing the plugin to fallback to 720p in most case.

Additional references

Codes mostly taken from youtubedl's project

@pep8speaks
Copy link

pep8speaks commented May 24, 2024

Hello @m0n4! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 294:89: E501 line too long (92 > 88 characters)
Line 295:89: E501 line too long (92 > 88 characters)
Line 296:89: E501 line too long (93 > 88 characters)
Line 297:89: E501 line too long (93 > 88 characters)
Line 298:89: E501 line too long (94 > 88 characters)
Line 299:89: E501 line too long (93 > 88 characters)
Line 300:89: E501 line too long (93 > 88 characters)
Line 301:89: E501 line too long (93 > 88 characters)
Line 302:89: E501 line too long (96 > 88 characters)
Line 303:89: E501 line too long (96 > 88 characters)
Line 304:89: E501 line too long (94 > 88 characters)
Line 305:89: E501 line too long (94 > 88 characters)
Line 306:89: E501 line too long (95 > 88 characters)
Line 307:89: E501 line too long (97 > 88 characters)
Line 308:89: E501 line too long (92 > 88 characters)
Line 309:89: E501 line too long (92 > 88 characters)
Line 310:89: E501 line too long (93 > 88 characters)
Line 311:89: E501 line too long (95 > 88 characters)
Line 312:89: E501 line too long (94 > 88 characters)
Line 313:89: E501 line too long (94 > 88 characters)
Line 314:89: E501 line too long (95 > 88 characters)
Line 315:89: E501 line too long (93 > 88 characters)
Line 316:89: E501 line too long (93 > 88 characters)
Line 317:89: E501 line too long (93 > 88 characters)
Line 318:89: E501 line too long (94 > 88 characters)
Line 319:89: E501 line too long (96 > 88 characters)
Line 320:89: E501 line too long (96 > 88 characters)
Line 321:89: E501 line too long (93 > 88 characters)
Line 322:89: E501 line too long (94 > 88 characters)
Line 323:89: E501 line too long (94 > 88 characters)
Line 324:89: E501 line too long (97 > 88 characters)
Line 325:89: E501 line too long (94 > 88 characters)
Line 326:89: E501 line too long (94 > 88 characters)
Line 327:89: E501 line too long (94 > 88 characters)
Line 328:89: E501 line too long (94 > 88 characters)
Line 329:89: E501 line too long (94 > 88 characters)
Line 330:89: E501 line too long (94 > 88 characters)
Line 331:89: E501 line too long (94 > 88 characters)
Line 332:89: E501 line too long (95 > 88 characters)
Line 333:89: E501 line too long (97 > 88 characters)
Line 334:89: E501 line too long (96 > 88 characters)
Line 335:89: E501 line too long (96 > 88 characters)
Line 336:89: E501 line too long (97 > 88 characters)
Line 337:89: E501 line too long (97 > 88 characters)
Line 338:89: E501 line too long (94 > 88 characters)
Line 339:89: E501 line too long (95 > 88 characters)
Line 340:89: E501 line too long (96 > 88 characters)
Line 341:89: E501 line too long (96 > 88 characters)
Line 342:89: E501 line too long (97 > 88 characters)
Line 343:89: E501 line too long (96 > 88 characters)
Line 344:89: E501 line too long (96 > 88 characters)
Line 345:89: E501 line too long (97 > 88 characters)
Line 346:89: E501 line too long (97 > 88 characters)
Line 347:89: E501 line too long (97 > 88 characters)
Line 348:89: E501 line too long (94 > 88 characters)
Line 349:89: E501 line too long (94 > 88 characters)
Line 350:89: E501 line too long (94 > 88 characters)
Line 351:89: E501 line too long (94 > 88 characters)
Line 352:89: E501 line too long (96 > 88 characters)
Line 353:89: E501 line too long (97 > 88 characters)
Line 354:89: E501 line too long (97 > 88 characters)
Line 355:89: E501 line too long (97 > 88 characters)
Line 356:89: E501 line too long (93 > 88 characters)
Line 357:89: E501 line too long (93 > 88 characters)
Line 358:89: E501 line too long (93 > 88 characters)
Line 359:89: E501 line too long (93 > 88 characters)
Line 360:89: E501 line too long (95 > 88 characters)
Line 361:89: E501 line too long (96 > 88 characters)
Line 362:89: E501 line too long (96 > 88 characters)
Line 363:89: E501 line too long (96 > 88 characters)
Line 364:89: E501 line too long (96 > 88 characters)

We recommend to use black to automatically correct these files.

Comment last updated at 2024-06-11 19:29:11 UTC

@m0n4 m0n4 changed the base branch from main to develop June 11, 2024 19:28
@m0n4
Copy link
Author

m0n4 commented Jun 11, 2024

I change destination branch to pyload:develop after reading a comment in another PR

@GammaC0de
Copy link
Member

Hi,
I have plans to update the plugin to not rely on ITAGs, this is why I don't accept this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants