fix(aws): Assume role for Gov Cloud #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
jfagoagas
commented
Jun 17, 2024
| @@ -850,8 +850,7 @@ def assume_role( | |||
| mfa_info = self.__input_role_mfa_token_and_code__() | |||
| assume_role_arguments["SerialNumber"] = mfa_info.arn | |||
| assume_role_arguments["TokenCode"] = mfa_info.totp | |||
|
|
|||
| sts_client = create_sts_session(session, AWS_STS_GLOBAL_ENDPOINT_REGION) | |||
There was a problem hiding this comment.
This is the issue here, we were always assuming a role with the Global STS Endpoint Region which is us-east-1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 818 818
Lines 25698 25709 +11
=======================================
+ Hits 22279 22289 +10
- Misses 3419 3420 +1 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Jun 17, 2024
Co-authored-by: Sergio Garcia <[email protected]>
sergargar
deleted the
PRWLR-3913-bug-assume-role-region-is-not-valid-for-gov-cloud-regions-4244
branch
|
I'm not sure about this backport, we have to check it manually in v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4244
Description
Handle AWS Gov Cloud partition while assuming roles.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.