feat(DocumentDB): New DocumentDB checks #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
+ Coverage 86.65% 86.78% +0.12%
==========================================
Files 818 833 +15
Lines 25703 26114 +411
==========================================
+ Hits 22272 22662 +390
- Misses 3431 3452 +21 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Jun 20, 2024
| "CLI": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#", | ||
| "NativeIaC": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#", | ||
| "Other": "", | ||
| "Terraform": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#" |
There was a problem hiding this comment.
Suggested change
| "Terraform": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#" | |
| "Terraform": "https://docs.prowler.com/checks/aws/general-policies/bc_aws_general_28/" |
sergargar
reviewed
Jun 20, 2024
| "RelatedUrl": "https://docs.aws.amazon.com/securityhub/latest/userguide/documentdb-controls.html#documentdb-1", | ||
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#", |
There was a problem hiding this comment.
Suggested change
| "CLI": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/encryption-enabled.html#", | |
| "CLI": "https://docs.prowler.com/checks/aws/general-policies/bc_aws_general_28/", |
sergargar
reviewed
Jun 20, 2024
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "documentdb_cluster_c_log_export", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "documentdb_cluster_c_log_export", | |
| "CheckID": "documentdb_cluster_cloudwatch_log_export", |
sergargar
reviewed
Jun 20, 2024
Comment on lines
21
to
22
| cluster.backup_retention_period > 0 | ||
| and cluster.backup_retention_period < 7 |
There was a problem hiding this comment.
Could you put this as a configurable variable, please?
|
Addressed all the comments. |
sergargar
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
New Checks
Modified Checks
Description
Trend Conformity: https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/aws/DocumentDB/
AWS Security Hub: https://docs.aws.amazon.com/securityhub/latest/userguide/documentdb-controls.html
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.