explain how to ignore WAL files and cleanup resulting grafs #14317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Jun 20, 2024
docs/storage.md
Outdated
Comment on lines
76
to
77
| in durability, performance, and efficiency. With proper architecture, | ||
| it is possible to retain years of data in local storage. |
There was a problem hiding this comment.
I think this last bit was originally saying you don't need external storage, so moving it here changes the meaning.
There was a problem hiding this comment.
i moved it back, is it okay now?
docs/storage.md
Outdated
| Careful evaluation is required for these systems as they vary greatly in durability, | ||
| performance, and efficiency. | ||
| the last WAL sync, which typically happens every two hours, covering | ||
| the last three hours of samples. Excluding the WAL files (the `wal/` |
There was a problem hiding this comment.
Suggest inserting "If snapshots are unavailable" here, to emphasise we are not changing the recommendation.
There was a problem hiding this comment.
i tweaked it a little further, see if that is okay with you.
We don't want do backup WAL files, but we should just show how to actually ignore those files. Also explain what happens every 2 hours a little more clearly and move things around so the paragraphs flow more easily. Followup for prometheus#14297. Signed-off-by: Antoine Beaupré <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want do backup WAL files, but we should just show how to actually ignore those files. Also explain what happens every 2 hours a little more clearly and move things around so the paragraphs flow more easily.
Followup for #14297.