Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): updated the name of Twitter to X #3066

Closed
wants to merge 5 commits into from
Closed

chore(docs): updated the name of Twitter to X #3066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94bb0e2
Updated the name of Twitter to X
tvermaashutosh Oct 30, 2023
8c999b7
Updated .all-contributorsrc
tvermaashutosh Oct 30, 2023
72d3ab4
Updated construct-lib.ts
tvermaashutosh Oct 30, 2023
26022b7
Updated README.md
tvermaashutosh Oct 30, 2023
9f0811a
Updated API.md
tvermaashutosh Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .all-contributorsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@
"login": "bracki",
"name": "Jan Brauer",
"avatar_url": "https://avatars.githubusercontent.com/u/49786?v=4",
"profile": "http://twitter.com/bracki",
"profile": "http://x.com/bracki",
"contributions": ["code"]
},
{
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="https://github.com/cogwirrel"><img src="https://avatars.githubusercontent.com/u/1848603?v=4?s=100" width="100px;" alt="Jack Stevenson"/><br /><sub><b>Jack Stevenson</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=cogwirrel" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/jmourelos"><img src="https://avatars3.githubusercontent.com/u/3878434?v=4?s=100" width="100px;" alt="Jacob"/><br /><sub><b>Jacob</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=jmourelos" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://joapy.com/"><img src="https://avatars3.githubusercontent.com/u/325306?v=4?s=100" width="100px;" alt="Jake Pearson"/><br /><sub><b>Jake Pearson</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=jakepearson" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://twitter.com/bracki"><img src="https://avatars.githubusercontent.com/u/49786?v=4?s=100" width="100px;" alt="Jan Brauer"/><br /><sub><b>Jan Brauer</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=bracki" title="Code">💻</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs reverting

<td align="center" valign="top" width="14.28%"><a href="http://x.com/bracki"><img src="https://avatars.githubusercontent.com/u/49786?v=4?s=100" width="100px;" alt="Jan Brauer"/><br /><sub><b>Jan Brauer</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=bracki" title="Code">💻</a></td>
</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/jmalins"><img src="https://avatars.githubusercontent.com/u/2001356?v=4?s=100" width="100px;" alt="Jeff Malins"/><br /><sub><b>Jeff Malins</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=jmalins" title="Code">💻</a></td>
Expand Down
2 changes: 1 addition & 1 deletion docs/api/API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/cdk/construct-lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ export interface ConstructLibraryOptions extends JsiiProjectOptions {
*
* https://awscdk.io/packages/[@SCOPE/]PACKAGE@VERSION
*
* The catalog will also post a tweet to https://twitter.com/awscdkio with the
* The catalog will also post a tweet to https://x.com/awscdkio with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The catalog will also post a tweet to https://x.com/awscdkio with the
* The catalog will also post to https://x.com/awscdkio with the

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wait a minute. I'm making the required changes.

* package name, description and the above link. You can disable these tweets
* through `{ announce: false }`.
*
* You can also add a Twitter handle through `{ twitter: 'xx' }` which will be
* You can also add a X handle through `{ X: 'xx' }` which will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You can also add a X handle through `{ X: 'xx' }` which will be
* You can also add a X handle through `{ twitter: 'xx' }` which will be

This is an external API the can't changed unilaterally from here.

* mentioned in the tweet.
*
* @see https://github.com/construct-catalog/catalog
Expand All @@ -23,7 +23,7 @@ export interface ConstructLibraryOptions extends JsiiProjectOptions {

export interface Catalog {
/**
* Twitter account to @mention in announcement tweet.
* X account to @mention in announcement tweet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add something like (previously Twitter) to explain the difference in docs and property.

*/
readonly twitter?: string;

Expand Down
Loading