Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4844] Serializer update for ordering by storageclass #5174

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Jun 18, 2024

Jira Ticket

COST-4844

Description

This change will allow you to order by storageclass when grouping by storageclass

Testing

http://localhost:8000/api/cost-management/v1/reports/openshift/volumes/?group_by%5Bstorageclass%5D=*&order_by%5Bstorage_class%5D=desc

Release Notes

  • proposed release note
* [COST-4844](https://issues.redhat.com/browse/COST-4844) Tweak serializer for storageclass order by

@myersCody myersCody requested review from a team as code owners June 18, 2024 17:28
@myersCody myersCody added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Jun 18, 2024
@myersCody
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (011ec69) to head (f33ec89).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5174   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        376     376           
  Lines      31230   31233    +3     
  Branches    3725    3727    +2     
=====================================
+ Hits       29410   29414    +4     
+ Misses      1161    1158    -3     
- Partials     659     661    +2     

@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody enabled auto-merge (squash) June 27, 2024 18:41
@myersCody myersCody merged commit 25e3062 into main Jun 27, 2024
11 checks passed
@myersCody myersCody deleted the cost-4844-order-by-update branch June 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests smokes-required
Projects
None yet
2 participants