Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4945] Create a new API to return list of EC2-compute instances #5117

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

bacciotti
Copy link
Contributor

@bacciotti bacciotti commented May 20, 2024

Jira Ticket

COST-4945

Description

This change will create a new API to return a list of AWS EC2-Compute instances.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint api/cost-management/v1/reports/aws/resources/ec2-compute/?filter[time_scope_value]=-1&filter[time_scope_units]=month&filter[resolution]=monthly
    1. You should see some EC2 data, like operating_system, vcpu, memory
  4. Run tox tests with tox -e py39 -- api.report.test.aws.test_views.AWSReportViewTest

Release Notes

  • New API to return a list of AWS EC2-Compute instances.
* [COST-4945](https://issues.redhat.com/browse/COST-4945) Create a new API to return a list of AWS EC2-Compute instances.

@bacciotti bacciotti added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 87.42138% with 20 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (e2c2fd5) to head (e9b96fc).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5117     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        375     375             
  Lines      31208   31330    +122     
  Branches    3730    3746     +16     
=======================================
+ Hits       29377   29487    +110     
- Misses      1165    1177     +12     
  Partials     666     666             

@cgoodfred cgoodfred removed the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label May 28, 2024
@djnakabaale djnakabaale removed the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label Jun 5, 2024
@djnakabaale djnakabaale added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests smokes-required
Projects
None yet
4 participants