-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4945] Create a new API to return list of EC2-compute instances #5117
Draft
bacciotti
wants to merge
56
commits into
main
Choose a base branch
from
cost-4945_awsec2_compute_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacciotti
added
the
aws-smoke-tests
pr_check will build the image and run aws + ocp on aws smoke tests
label
May 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5117 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 375 375
Lines 31208 31330 +122
Branches 3730 3746 +16
=======================================
+ Hits 29377 29487 +110
- Misses 1165 1177 +12
Partials 666 666 |
cgoodfred
removed
the
aws-smoke-tests
pr_check will build the image and run aws + ocp on aws smoke tests
label
May 28, 2024
…u/koku into cost-4945_awsec2_compute_api
djnakabaale
removed
the
aws-smoke-tests
pr_check will build the image and run aws + ocp on aws smoke tests
label
Jun 5, 2024
djnakabaale
added
the
aws-smoke-tests
pr_check will build the image and run aws + ocp on aws smoke tests
label
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4945
Description
This change will create a new API to return a list of AWS EC2-Compute instances.
Testing
api/cost-management/v1/reports/aws/resources/ec2-compute/?filter[time_scope_value]=-1&filter[time_scope_units]=month&filter[resolution]=monthly
tox -e py39 -- api.report.test.aws.test_views.AWSReportViewTest
Release Notes