-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4912] Calculate node based unattributed storage (Azure) #5066
base: main
Are you sure you want to change the base?
Conversation
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 376 376
Lines 31230 31238 +8
Branches 3725 3726 +1
=====================================
+ Hits 29410 29419 +9
+ Misses 1161 1160 -1
Partials 659 659 |
koku/masu/database/trino_sql/reporting_ocpazurecostlineitem_daily_summary.sql
Outdated
Show resolved
Hide resolved
…ily_summary.sql Co-authored-by: Michael Skarbek <[email protected]>
koku/masu/database/sql/reporting_ocpazure_ocp_infrastructure_back_populate.sql
Outdated
Show resolved
Hide resolved
koku/masu/database/sql/reporting_ocpazure_ocp_infrastructure_back_populate.sql
Outdated
Show resolved
Hide resolved
koku/masu/database/sql/reporting_ocpazure_ocp_infrastructure_back_populate.sql
Outdated
Show resolved
Hide resolved
koku/masu/database/trino_sql/reporting_ocpazurecostlineitem_daily_summary.sql
Outdated
Show resolved
Hide resolved
koku/masu/database/trino_sql/reporting_ocpazurecostlineitem_daily_summary.sql
Outdated
Show resolved
Hide resolved
Successful Azure Smokes: https://ci.ext.devshift.net/job/koku-pipeline-pr-check-main/2468/ |
checking out to this branch:
and enabling unnatributed cost in unleash.
run the IQE command:
this will set a breakpoint at the beggining of the tests, when the sources finish their setup double check storage.unnatributed is ON
thes test is gonna fail, because we did not add to the reports the volume handles, and some storage cost will move to unnatributed the weird thing is that the API calls:
returns empty values
I am not aware at any changes at this API are expected setting the flag to off makes raw calc pass, and the API returns not empty values |
Jira Ticket
COST-3912
Description
This change will calculate the node based unattributed storage for Azure.
Testing
make create-test-customer
make load-test-customer-data test_source=Azure
Storage unattributed
namespace was populated:The claimless will be be 100% unattributed cost; however, we can check our other resource to see that the cost was split:
This will set it back to being False.
8. Resummarize the Azure source
9. Recheck the database to see if unattributed storage was added:
Release Notes
proposed release note
https://gist.github.com/myersCody/b300fea8db309e55d50a7bf020a8e4b8