docs(CONTRIBUTING): Actually include rebuilding the package in instructions #24379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolg42
reviewed
Jun 10, 2024
Comment on lines
+77
to
+79
| # Edit the desired package and build it | ||
| # (or similar command, see above) | ||
| pnpm -r run build |
There was a problem hiding this comment.
I think this is confusing here.
Because you want to say to run this in the root directory, right? Here we are in ./sandbox
There was a problem hiding this comment.
Also pnpm -w run build is enough and can be run from almost anywhere (except ./sandbox because it has a pnpm-workspace.yaml
-w means the command will run from the root directory, and it is configured as "build": "pnpm -r build",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…