Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven-shade-plugin to 3.6.0 #23050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade maven-shade-plugin to 3.6.0 #23050

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 21, 2024

Description

Latest version of shade plugin

Motivation and Context

Hit some shading problems in build

Impact

none

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo requested a review from rschlussel June 24, 2024 11:04
@elharo elharo marked this pull request as ready for review June 24, 2024 11:04
@elharo elharo requested a review from a team as a code owner June 24, 2024 11:04
@elharo elharo requested a review from presto-oss June 24, 2024 11:04
@rschlussel
Copy link
Contributor

what problems does this fix? Are there any risks with the upgrade?

@elharo
Copy link
Contributor Author

elharo commented Jun 24, 2024

I've been noticing some failures in shading in the Meta builds lately, typically failing to load artifacts from the repo. They seem a little flaky and I haven't root caused them yet. However, we are a couple of years behind this release, and there've been some significant bug fixes including better JDK 11 support:

https://github.com/apache/maven-shade-plugin/releases

@elharo
Copy link
Contributor Author

elharo commented Jun 26, 2024

Possibly flaky failure in TaskManagerTest.buildSpillDirectoryFailure

9: E20240625 10:11:10.096318 10664 Exceptions.h:67] Line: /root/project/presto-native-execution/velox/velox/exec/Task.cpp:1869, Function:terminate, Expression:  Aborted for external error, Source: RUNTIME, ErrorCode: INVALID_STATE
9: E20240625 10:11:10.096730 10664 TaskManager.cpp:282] There are 1 zombie Task that satisfy cleanup conditions but could not be cleaned up, because the Task are referenced by more than 1 owners. RUNNING[0] FINISHED[0] CANCELED[0] ABORTED[1] FAILED[0]  Sample task IDs (shows only 20 IDs): 
9: E20240625 10:11:10.096768 10664 TaskManager.cpp:292] Zombie Task [1/1]: Extra Refs: 1, test.0.0.0.0
9: E20240625 10:11:13.272599 10664 Exceptions.h:67] Line: /root/project/presto-native-execution/velox/velox/exec/tests/utils/QueryAssertions.cpp:1458, Function:waitForAllTasksToBeDeleted, Expression: numDeletedTasks == numCreatedTasks (87 vs. 88) 88 tasks have been created while only 87 have been deleted after waiting for 3000000 us, Source: RUNTIME, ErrorCode: INVALID_STATE
9: unknown file: Failure
9: C++ exception with description "Exception: VeloxRuntimeError
9: Error Source: RUNTIME
9: Error Code: INVALID_STATE
9: Reason: (87 vs. 88) 88 tasks have been created while only 87 have been deleted after waiting for 3000000 us
9: Retriable: False
9: Expression: numDeletedTasks == numCreatedTasks
9: Function: waitForAllTasksToBeDeleted
9: File: /root/project/presto-native-execution/velox/velox/exec/tests/utils/QueryAssertions.cpp
9: Line: 1458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants