Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Low Confidence, 0 estimations as unknown during joins #23047

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhinavmuk04
Copy link
Contributor

@abhinavmuk04 abhinavmuk04 commented Jun 21, 2024

Description

Treat Low Confidence, 0 estimations as unknown during joins

Motivation and Context

When a node has a low confidence and a 0 estimation it is likely due to the fact that there has been multiple filters pushed down on it. Additionally, sometimes this estimation can actually be so incorrect that it can have us broadcasting the wrong side entirely leading to a failed query. This will help us avoid this.

Impact

This can result in faster query execution times and improved overall performance.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@abhinavmuk04 abhinavmuk04 force-pushed the milestone2p2 branch 2 times, most recently from 2d27492 to 46c1268 Compare June 27, 2024 21:52
@abhinavmuk04 abhinavmuk04 changed the title Treat 0 Estimations as NaN Treat 0 Estimations from TableScan as NaN Jun 27, 2024
@abhinavmuk04 abhinavmuk04 changed the title Treat 0 Estimations from TableScan as NaN Treat Low Confidence, 0 estimations as unknown during joins Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant