Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keybinds_hint.sh maintenance #1520

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix: keybinds_hint.sh maintenance #1520

wants to merge 14 commits into from

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented May 18, 2024

Pull Request

Adding some comprehensive help message
image

  • Fix the space on the SUPER 
  • For now add an option to how may lines can be rendered.

@kRHYME7 kRHYME7 requested a review from Skerse May 18, 2024 00:34
@kRHYME7 kRHYME7 marked this pull request as ready for review May 18, 2024 00:34
@kRHYME7 kRHYME7 changed the title fix: keybinds_hint.sh maintainance fix: keybinds_hint.sh maintenance May 18, 2024
@dieBakterie
Copy link
Contributor

I had to add the paths with an leading and ending space and $HOME to work properply.
So kb_hint_confs=" $HOME/.config/hypr/silos.conf $HOME/.config/hypr/scratchpads.conf " works but kb_hint_paths="~/.config/hypr/silos.conf ~/.config/hypr/scratchpads.conf" for it to work properly on my end. I haven't understand at first what was meant with spaces, could be only neccessary for me 'cause my fork is modified a lot.

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 19, 2024

@dieBakterie thanks. got lazy to treat it as array lol.

now you can just use the bash array conventions

kb_hint_conf=("file1.conf" "file2.conf") ﯦ add a custom keybinds.conf path (add it like an array)

@kRHYME7 kRHYME7 requested a review from rubiin May 26, 2024 10:24
@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Jun 22, 2024

Updated the script to handle bindd explicitly added description.

kRHYME7 and others added 4 commits June 23, 2024 01:15
Addition of the -h param in the example and HELP message, minor tweaks and some globbing fixed?
`-*` instead of `--help`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants